Conversation
newpavlov
reviewed
May 17, 2018
src/lib.rs
Outdated
| // are weird. Maybe a different version of LLVM will react differently, so if | ||
| // you see this comment in the future try deleting this assignment and using | ||
| // uninit above and see how it affects the benchmarks. | ||
| arrays[i][x] = 0; |
Contributor
There was a problem hiding this comment.
After loop was unrolled you don't need this anymore. This variant has the same speed for me.
Contributor
Author
There was a problem hiding this comment.
Fantastic, I was really hoping I could get rid of this (as you can see from my comment).
Contributor
There was a problem hiding this comment.
fwiw I tried using uninitialised memory yesterday to see if a newer compiler did anything different – it did not (well, it made the whole thing slower just like you said in the comment).
Contributor
Confirmed. :) LGTM |
Contributor
Author
|
@debris Can you merge this? |
This was referenced May 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves binary size and (reportedly) speed, too